View Change
2 comments:
Commit Message:
Patch Set #2, Line 12:
src/drivers/tpm/tpm.c takes care of
initializing TPM (see Kconfig option TPM_INIT).
So, were the devices getting initialized twice currently if VBOOT is not selected -- i.e. […]
I guess we are going to run into more problems with !VBOOT if we leave this code in here...
What about the suggestion in the comment below about a new Kconfig flag?
Patch Set #2, Line 14:
TPM will be initialized whenever
verstage is executed, depending on how the device is configured
I am okay if you want to just add a condition saying that RECOVERY_MRC_CACHE hash is maintained in T […]
Thanks for letting me know about this -- I had no idea that RECOVERY_MRC_CACHE triggered TPM read/writes.
Since I'd like to keep some devices working with STARTS_IN_BOOTBLOCK for test purposes, how about fixing it to work? (See latest patchset.)
Alternatively, we could also introduce a more general Kconfig option... I was thinking TPM_EARLY_INIT might be a good pair for TPM_INIT. We can specify that they are mutually exclusive.
- TPM_EARLY_INIT: Something earlier than the ramstage TPM init code starts up the TPM.
- TPM_INIT: Ramstage TPM init code starts up the TPM.
- [Neither, but with VBOOT]: Vboot takes care of it when neither of these flags are enabled.
- [None]: TPM is not enabled.
To view, visit change 31837. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ba91c275c33245be61041cb592e52f861dbafe6
Gerrit-Change-Number: 31837
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 12 Mar 2019 16:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment