29 comments:
File src/soc/mediatek/mt8192/include/soc/pmif.h:
Use tabs and align all of these comments.
File src/soc/mediatek/mt8192/include/soc/pmif_spi.h:
Patch Set #28, Line 45: #define mtk_iocfg_tl ((struct mtk_iocfg_tl_regs *)IOCFG_TL_BASE)
Why not use a global variable just like mtk_pmicspi_mst?
Patch Set #28, Line 51: #define mtk_modem_temp_share ((struct mtk_modem_temp_share_regs *)SPM_BASE)
Why not use a global variable just like mtk_pmicspi_mst?
No need for parentheses here.
No need for parentheses.
Use lowercase "x"?
File src/soc/mediatek/mt8192/include/soc/pmif_spmi.h:
No need for parentheses.
File src/soc/mediatek/mt8192/pmif.c:
Patch Set #28, Line 15: unsigned int
Use "long" to be consistent with the signature of stopwatch_init_usecs_expire().
Patch Set #28, Line 15: unsigned int
int
Patch Set #28, Line 16: unsigned int
u32
Patch Set #28, Line 18: unsigned int
u32
Patch Set #28, Line 31: unsigned int
If it's boolean, use "int". Otherwise, consider u32, u16 or u8. Same for other similar arguments.
No need for these.
Patch Set #28, Line 46: if (write == 1)
if (write)
Patch Set #28, Line 55: if (write == 0)
if (!write)
Patch Set #28, Line 74: *data = 0;
Is this for timeout case in pmif_send_cmd()?
No need for these. Better to write
data >>= shift;
No need for these. Better to write
data >>= shift;
Patch Set #28, Line 175: if (inf == PMIF_SPMI)
Check "mstid < ARRAY_SIZE(pmif_spmi_arb)".
Remove this blank line.
File src/soc/mediatek/mt8192/pmif_spi.c:
After confirming with DE, they are random numbers in order to verify the read-back data.
Ack
File src/soc/mediatek/mt8192/pmif_spi.c:
int
void
Can we use int?
Can we use int?
Patch Set #28, Line 176: const u32 test_data[30] = {
Add a comment
/* Random data for testing */
Patch Set #28, Line 206: size_t
int
File src/soc/mediatek/mt8192/pmif_spmi.c:
What does this "b" mean?
},
To view, visit change 45398. To unsubscribe, or for help writing mail filters, visit settings.