Hi all,

This patch set is a great initial step, it as-is fulfills DeltaLake project's immediate needs. Once it is merged, some enhancements could be planned:
a. An option name is associated with a data type, regardless of data source. Based on the data type, appropriate vpd_get_* can be used. get_option() takes option name as input, it looks up at a table to get the data type, pass the option name and data type to vpd_get_option(). vpd_get_option() calls appropriate vpd_get_* based on data type, to look up the option name. In other words, the vpd_get_option() design is very similar to cmos_get_option().
b. there are 6 existing options used in DeltaLake mainboard, they will be converted to above framework.
c. For a specific option, there are several possible sources (cmos/cbfs/vpd/gpio/i2c, etc). For a mainboard, not all options may come from same source. A mainboard will have a table to enumerate which option comes from which source.

Thanks,
Jonathan

Patch set 3:Code-Review +1

View Change

To view, visit change 45774. To unsubscribe, or for help writing mail filters, visit settings.