Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Matt DeVillier has uploaded this change for review.

View Change

mb/google/brya/var/*: Use name 'LCD0' for internal panel output

The GMA driver generates the brightness controls expecting the name LCD0,
so we need to use it here as well so that the DSDT and SSDT parts match.

TEST=build/boot Win11 on google/brya (redrix), verify brightness controls are
functional.

Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
---
M src/mainboard/google/brya/variants/anahera/overridetree.cb
M src/mainboard/google/brya/variants/anahera4es/overridetree.cb
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
M src/mainboard/google/brya/variants/banshee/overridetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/crota/overridetree.cb
M src/mainboard/google/brya/variants/dochi/overridetree.cb
M src/mainboard/google/brya/variants/felwinter/overridetree.cb
M src/mainboard/google/brya/variants/gimble/overridetree.cb
M src/mainboard/google/brya/variants/gimble4es/overridetree.cb
M src/mainboard/google/brya/variants/kano/overridetree.cb
M src/mainboard/google/brya/variants/marasov/overridetree.cb
M src/mainboard/google/brya/variants/mithrax/overridetree.cb
M src/mainboard/google/brya/variants/omnigul/overridetree.cb
M src/mainboard/google/brya/variants/osiris/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
M src/mainboard/google/brya/variants/skolas/overridetree.cb
M src/mainboard/google/brya/variants/skolas4es/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
M src/mainboard/google/brya/variants/taeko4es/overridetree.cb
M src/mainboard/google/brya/variants/taniks/overridetree.cb
M src/mainboard/google/brya/variants/vell/overridetree.cb
M src/mainboard/google/brya/variants/volmar/overridetree.cb
25 files changed, 29 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/80174/1
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb
index 1961e09..352a7d1 100644
--- a/src/mainboard/google/brya/variants/anahera/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb
@@ -89,7 +89,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Use ChromeOS privacy screen _HID
 				register "device[0].hid" = ""GOOG0010""
 				# Internal panel on the first port of the graphics chip
@@ -117,7 +117,7 @@
 			 chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
index c7cce88..6973854 100644
--- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
@@ -71,7 +71,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Use ChromeOS privacy screen _HID
 				register "device[0].hid" = ""GOOG0010""
 				# Internal panel on the first port of the graphics chip
@@ -99,7 +99,7 @@
 			 chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
index ca9c655..456bb2f 100644
--- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
@@ -199,7 +199,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "4"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/banshee/overridetree.cb b/src/mainboard/google/brya/variants/banshee/overridetree.cb
index 38c4528..6f66bce 100644
--- a/src/mainboard/google/brya/variants/banshee/overridetree.cb
+++ b/src/mainboard/google/brya/variants/banshee/overridetree.cb
@@ -98,7 +98,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb
index a4a0ae5..876e874 100644
--- a/src/mainboard/google/brya/variants/brya0/overridetree.cb
+++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb
@@ -122,7 +122,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb
index 8b671e1..69f78c1 100644
--- a/src/mainboard/google/brya/variants/crota/overridetree.cb
+++ b/src/mainboard/google/brya/variants/crota/overridetree.cb
@@ -111,7 +111,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/dochi/overridetree.cb b/src/mainboard/google/brya/variants/dochi/overridetree.cb
index 880b7bc..461a7ad 100644
--- a/src/mainboard/google/brya/variants/dochi/overridetree.cb
+++ b/src/mainboard/google/brya/variants/dochi/overridetree.cb
@@ -91,7 +91,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
index 74f2114..28e0974 100644
--- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb
+++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
@@ -97,7 +97,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb
index 0de70e5..ed8027d 100644
--- a/src/mainboard/google/brya/variants/gimble/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb
@@ -78,7 +78,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
index 6351248..881c1a1 100644
--- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
@@ -43,7 +43,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb
index cbce022..aeb8ef2 100644
--- a/src/mainboard/google/brya/variants/kano/overridetree.cb
+++ b/src/mainboard/google/brya/variants/kano/overridetree.cb
@@ -100,7 +100,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb
index 64ca6a7..5a266dd 100644
--- a/src/mainboard/google/brya/variants/marasov/overridetree.cb
+++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb
@@ -145,7 +145,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/mithrax/overridetree.cb b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
index 6df9b60..55026ae 100644
--- a/src/mainboard/google/brya/variants/mithrax/overridetree.cb
+++ b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
@@ -95,7 +95,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
index 4a3d368..0ca36a7 100644
--- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb
+++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
@@ -130,7 +130,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/osiris/overridetree.cb b/src/mainboard/google/brya/variants/osiris/overridetree.cb
index 0c21a61..72981cf 100644
--- a/src/mainboard/google/brya/variants/osiris/overridetree.cb
+++ b/src/mainboard/google/brya/variants/osiris/overridetree.cb
@@ -74,7 +74,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb
index d815587..7dde42f 100644
--- a/src/mainboard/google/brya/variants/primus/overridetree.cb
+++ b/src/mainboard/google/brya/variants/primus/overridetree.cb
@@ -86,7 +86,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index f8502aa..1fe1682 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -104,7 +104,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Use ChromeOS privacy screen _HID
 				register "device[0].hid" = ""GOOG0010""
 				# Internal panel on the first port of the graphics chip
@@ -132,7 +132,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
index 6e00215..b68dec2 100644
--- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
@@ -85,7 +85,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Use ChromeOS privacy screen _HID
 				register "device[0].hid" = ""GOOG0010""
 				# Internal panel on the first port of the graphics chip
@@ -113,7 +113,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb
index 3f17008..e3879bc 100644
--- a/src/mainboard/google/brya/variants/skolas/overridetree.cb
+++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb
@@ -121,7 +121,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
index 326c675..7826ea8 100644
--- a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
@@ -116,7 +116,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb
index 27584cd..d6ffb7f 100644
--- a/src/mainboard/google/brya/variants/taeko/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb
@@ -141,7 +141,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "3"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
index 22b3ca7..753e7ba 100644
--- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
@@ -122,7 +122,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "3"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb
index 1e0101a..a2d9512 100644
--- a/src/mainboard/google/brya/variants/taniks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb
@@ -118,7 +118,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "3"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb
index 6956312..459f782 100644
--- a/src/mainboard/google/brya/variants/vell/overridetree.cb
+++ b/src/mainboard/google/brya/variants/vell/overridetree.cb
@@ -97,7 +97,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "5"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/volmar/overridetree.cb b/src/mainboard/google/brya/variants/volmar/overridetree.cb
index 1de6626..ef2da0a 100644
--- a/src/mainboard/google/brya/variants/volmar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/volmar/overridetree.cb
@@ -92,7 +92,7 @@
 			chip drivers/gfx/generic
 				register "device_count" = "6"
 				# DDIA for eDP
-				register "device[0].name" = ""LCD""
+				register "device[0].name" = ""LCD0""
 				# Internal panel on the first port of the graphics chip
 				register "device[0].addr" = "0x80010400"
 				# DDIB for HDMI

To view, visit change 80174. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Gerrit-Change-Number: 80174
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Eric Lai <ericllai@google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-MessageType: newchange