[coreboot-gerrit] Change in coreboot[master]: cbfstool: Replace FILENAME_ALIGN 16 with ATTRIBUTE_ALIGN 4

[Julius Werner (Code Review)]

Attention is currently required from: Furquan Shaikh, Angel Pons.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47827 )

Change subject: cbfstool: Replace FILENAME_ALIGN 16 with ATTRIBUTE_ALIGN 4
......................................................................

Patch Set 11:

(1 comment)

File src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h:

https://review.coreboot.org/c/coreboot/+/47827/comment/99205c0d_f46b183a 
PS11, Line 118: #define CBFS_ATTRIBUTE_ALIGN 4
> Should we add an _Static_assert for existing attribute structs to guarantee that? This would also ma […]

I mean, I could do it for the structs that are fixed-size, but the problem is that not all of them are.  So my solution here is basically just to put that (non-static) assert into cbfstool, and then if you added an attribute like that you'd still notice very quickly when trying out your code.