I feel like two comments right above each other looks kinda ugly. I also don't think we'll be able to maintain it unless you put in a linter check for it.

Do we even need that "part of the coreboot project" line? Does anyone care about that being there? For all I care, I'd be fine with just taking it out completely...

(Also, I think ideally the SPDX identifier is supposed to be the first line, so if anything we might want to move all the coreboot project lines below that.)

View Change

1 comment:

• File src/mainboard/google/trogdor/romstage.c:

  • Patch Set #1, Line 3: *

    nit: technically not comment style compliant with an extra blank line. I guess it doesn't matter if the next patch changes it anyway. Although this one in particular doesn't get changed due to slightly different license text.

To view, visit change 41065. To unsubscribe, or for help writing mail filters, visit settings.