Werner Zeh has uploaded this change for review.
mb/siemens/mc_ehl: Use SPD data from HW-Info in the first place
The preferred location for the SPD data on mc_ehl based boards is the
HW-Info data structure. Inside this structure there is a field of 128
bytes available for the SPD data. So in order to use it construct a
buffer in memory which is 256 bytes long (as FSP requests minimum 256
bytes for the SPD data) and where the upper 128 bytes are taken from
HW-Info holding the needed timing parameters for LPDDR4.
If there is a case where HW-Info is not accessible or where the
contained SPD data is not valid (by checking the CRC in HW-Info SPD)
fall back to fixed SPD data set in CBFS.
Change-Id: I2b6a1bde0306ba84f5214b876eaf76ca12d8f058
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
---
M src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
1 file changed, 22 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/58176/1
diff --git a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
index 259870a..a6ed234 100644
--- a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
+++ b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
@@ -1,20 +1,39 @@
/* SPDX-License-Identifier: GPL-2.0-only */
+#include <arch/mmio.h>
#include <baseboard/variants.h>
+#include <console/console.h>
+#include <device/dram/common.h>
+#include <hwilib.h>
#include <soc/meminit.h>
#include <soc/romstage.h>
+#include <string.h>
+#include <types.h>
void mainboard_memory_init_params(FSPM_UPD *memupd)
{
static struct spd_info spd_info;
const struct mb_cfg *board_cfg = variant_memcfg_config();
+ static uint8_t spd_data[0x100];
+ const char *cbfs_hwi_name = "hwinfo.hex";
/* TODO: Read the resistor strap to get number of memory segments */
bool half_populated = false;
- /* Initialize spd information for LPDDR4x board */
- spd_info.read_type = READ_SPD_CBFS;
- spd_info.spd_spec.spd_index = 0x00;
+ /* Initialize SPD information for LPDDR4x from HW-Info primarily with a fallback to
+ spd.bin in the case where the SPD data in HW-Info is not available or invalid. */
+ memset(spd_data, 0, sizeof(spd_data));
+ if ((hwilib_find_blocks(cbfs_hwi_name) == CB_SUCCESS) &&
+ (hwilib_get_field(SPD, spd_data, 0x80) == 0x80) &&
+ (ddr_crc16(spd_data, 126) == read16((void *)&spd_data[126]))) {
+ spd_info.spd_spec.spd_data_ptr_info.spd_data_ptr = (uintptr_t)spd_data;
+ spd_info.spd_spec.spd_data_ptr_info.spd_data_len = sizeof(spd_data);
+ spd_info.read_type = READ_SPD_MEMPTR;
+ } else {
+ printk(BIOS_WARNING, "SPD in HW-Info not valid, fall back to spd.bin!\n");
+ spd_info.read_type = READ_SPD_CBFS;
+ spd_info.spd_spec.spd_index = 0x00;
+ }
/* Initialize variant specific configurations */
memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, half_populated);
}
To view, visit change 58176. To unsubscribe, or for help writing mail filters, visit settings.