View Change

2 comments:

• File src/commonlib/bsd/include/commonlib/bsd/cbfs_private.h:

  • Patch Set #4, Line 116: (still big-endian)

    I don't understand why we're exposing serialized implementation details to callers in both the inputs and outputs.

  • Patch Set #4, Line 117: void *cbfs_find_attr(union cbfs_mdata *mdata, uint32_t attr_tag);

    Why are these pointers not pointing to const objects?

To view, visit change 39305. To unsubscribe, or for help writing mail filters, visit settings.