2 comments:
Patch Set #5, Line 148: if (spd_part_name_override && strlen(spd_part_name_override)) {
Since in this case, you don't know what type of `spd` it is you're dealing with, how do you know how […]
I had a different version that did what you suggest, but that change seemed overly complicated, and I realized that this was a static routine and was only called from one place, which already uses a string size for the biggest string it might encounter (DDR4 - 20 chars). But you're correct, this still should have had a MIN to assure that the override name is not longer than the jedec spec for the name size.
Patch Set #6, Line 154: /* verify whether LPDDR3_JEDEC size is same as LPDDR3 or DDR4 */
Tim, do you have or know where I can find a JEDEC SPD spec for LPDDR3_JEDEC? I need to know what the length of a LPDDR3_JEDEC Module Part Number size is.
To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.