View Change

22 comments:

• Commit Message:

  • Patch Set #40, Line 11: chrome

    Chromium OS?

  • Patch Set #40, Line 18: the coreboot

    Remove the article.

  • Patch Set #40, Line 19: partition(either BP1(RO) or BP2)

    Please add a space after *partition* before (.

• File src/soc/intel/common/block/cse/cse_bp.c:

  • Patch Set #40, Line 23: */

    Please add a space before.

  • Patch Set #40, Line 47: uint8_t

    Why not `unsigned int`?

  • Patch Set #40, Line 64: bool

    Use CB_SUCCESS and friends?

  • Patch Set #40, Line 89: printk(BIOS_ERR, "Get partition info resp failed:%d\n", info_resp.hdr.result);

    Please add a space after the colon.

  • Patch Set #40, Line 105:

    Remove the blank line.

  • Patch Set #40, Line 108: fail

    failed

  • Patch Set #40, Line 135: Command(BP%d)

    Please add a space before (.

  • Patch Set #40, Line 146: printk(BIOS_ERR, "Set Boot Partion Info Response Failed:%d\n",

    Ditto.

  • Patch Set #40, Line 182: return false;

    Above you print an error.

  • Patch Set #40, Line 305: No

    Number

  • Patch Set #40, Line 308: =0x%x

    Please add a space.

• File src/soc/intel/common/block/include/intelblocks/cse.h:

  • Patch Set #40, Line 172: Enabled

    lowercase

  • Patch Set #40, Line 174: * So, CSE Image contains 3 partitions when redundancy is enabled

    Period/dot at the end?

  • Patch Set #40, Line 180:

    Remove blank line.

  • Patch Set #40, Line 183: * and it's a valid bootable partition.

    Fits on one line?

  • Patch Set #40, Line 195: * not a bootable partition on it's own.

    One line?

  • Patch Set #40, Line 202:

    Remove blank line.

  • Patch Set #40, Line 262: };

    Might this be available in other parts of coreboot already?

  • Patch Set #40, Line 274: partition(BP1

    Space.

To view, visit change 35402. To unsubscribe, or for help writing mail filters, visit settings.