build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35497 ) Change subject: sc7180: Add gpio driver ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/c/coreboot/+/35497/7/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/gpio.h: https://review.coreboot.org/c/coreboot/+/35497/7/src/soc/qualcomm/sc7180/inc... PS7, Line 125: #define PIN(index, tlmm, func1, func2, func3, func4, func5, func6, func7) \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/35497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12bdbeb97765b6ae1e015ca35108008bf82801cc Gerrit-Change-Number: 35497 Gerrit-PatchSet: 7 Gerrit-Owner: mturney mturney <mturney@codeaurora.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: mturney mturney <mturney@codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 11 Oct 2019 01:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment