Attention is currently required from: Evan Green, Tim Wawrzynczak, Karthik Ramasubramanian.
Patch set 3:Code-Review +2
View Change
1 comment:
Commit Message:
Patch Set #3, Line 9: LTE module is not expected to be powered off during warm reset
There is no mention of Firmware reload after a warm reset in the LTE module hardware guide. […]
Overall, the change looks okay. It would be good to check with the LTE team to ensure they don't have any problem with the behavior i.e. LTE module will not be power cycled on warm reboot.
To view, visit change 48623. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8676da6186559288aabe078b6158fc01075c7b41
Gerrit-Change-Number: 48623
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Evan Green <evgreen@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Henry Sun <henrysun@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Allen Cheng <allen.cheng@lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang@lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh@lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu@lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao@lcfc.corp-partner.google.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Evan Green <evgreen@chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Comment-Date: Tue, 12 Jan 2021 23:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-MessageType: comment