Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Zhuohao Lee.
3 comments:
Patchset:
Move function declarations to the front of function body.
Add blank line after '}'.
File src/mainboard/google/brya/variants/baseboard/brask/ramstage.c:
if (!num_entries)
return;
const struct device *policy_dev = DEV_PTR(dptf_policy);
if (!policy_dev)
return;
size_t intel_idx, brask_idx;
if (!get_sku_index(limits, num_entries, &intel_idx, &brask_idx))
return;
config_t *conf = config_of_soc();
struct soc_power_limits_config *soc_config = &conf->power_limits_config[intel_idx];
enum usb_chg_type type;
u32 watts;
u16 volts_mv, current_ma;
u32 psyspl2, pl2;
soc_config->tdp_pl4 = 0;
u32 pl2_default = DIV_ROUND_UP(limits[brask_idx].pl2_max_power, MILLIWATTS_TO_WATTS);
int rv = google_chromeec_get_usb_pd_power_info(&type, ¤t_ma, &volts_mv);
suggestion, slighly reorganize this for readability: […]
Done
Patch Set #16, Line 131: /* voltage unit is milliVolts and current is in milliAmps */
nit: blank line after `}`
Done
To view, visit change 58241. To unsubscribe, or for help writing mail filters, visit settings.