Martin Roth submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved
nb/intel/i945/raminit.c: Clean up includes and add <types.h>

Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: I94a81a30950cca6be5ba36a25f8bc6f87c2aad2f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68044
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index ee5c541..0a4794a 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -1,22 +1,24 @@
/* SPDX-License-Identifier: GPL-2.0-only */

+#include <cf9_reset.h>
#include <console/console.h>
#include <delay.h>
-#include <device/pci_def.h>
-#include <device/pci_ops.h>
-#include <device/smbus_host.h>
-#include <cf9_reset.h>
-#include <device/mmio.h>
#include <device/device.h>
+#include <device/dram/ddr2.h>
+#include <device/mmio.h>
+#include <device/pci_ops.h>
+#include <device/pci_type.h>
+#include <device/smbus_host.h>
#include <lib.h>
#include <pc80/mc146818rtc.h>
#include <spd.h>
#include <string.h>
+#include <timestamp.h>
+#include <types.h>
+
#include "raminit.h"
#include "i945.h"
#include "chip.h"
-#include <device/dram/ddr2.h>
-#include <timestamp.h>

/* Debugging macros. */
#if CONFIG(DEBUG_RAM_SETUP)

To view, visit change 68044. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94a81a30950cca6be5ba36a25f8bc6f87c2aad2f
Gerrit-Change-Number: 68044
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged