Patch set 15:Code-Review +1
5 comments:
File util/smc/smcbiosinfo/smcbiosinfo.c:
Patch Set #9, Line 100: ret = 0;
isn't printing a helpmessage doing it's job?
Yeah, right, I forgot how the code originally looked like. I'd say it's a success
in case of 'h' but a failure in case of '?'.
File util/smc/smcbiosinfo/smcbiosinfo.c:
Patch Set #13, Line 113: ret = strtol(s, NULL, 0);
No check if it could be parsed?
I think the easiest way is to provide `endptr` and check that `**endptr == '\0'`
after the call. Oh, and check that `*s != '\0'`, i.e. non-empty string.
File util/supermicro/Makefile.inc:
Patch Set #15, Line 4: SMCBIOSINFOTOOL:= $(obj)/smcbiosinfo
We also have an $(objutil) but, meh, I don't know when to use it...
Patch Set #15, Line 6: util/supermicro/smcbiosinfo
This could be $(dir), IIRC.
s/MAKE /HOSTCC/ ?
To view, visit change 35484. To unsubscribe, or for help writing mail filters, visit settings.