We can also check this in the makefile and kill the build if that's desired.

I would prefer a Makefile solution, because we wouldn't need
the fake Kconfig option. I just tried the following: moved the
`include $(DOTCONFIG)` up out of the `ifeq ($(NOCOMPILE)...`
then we could grep for the old setting in the new `.config`
after each `make *config`.

I'm not 100% convinced by either solution. I don't like the
fake Kconfig, but the Makefile code might get a little ugly.

In the Makefile case, we could even move the new, to be re-
paired .config away and revert the changes?

Also noticed, the MAINBOARD_DIR might not be enough, a variant
change could also create havoc.

Patch set 1:Code-Review +1

View Change

To view, visit change 33641. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a1ccb62c7678f264015c87b9004be6a106f804a
Gerrit-Change-Number: 33641
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 22 Jun 2019 11:47:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment