[coreboot-gerrit] [M] Change in coreboot[main]: security/tpm: Retrieve factory configuration for device w/ Google TPM

[Tim Van Patten (Code Review)]

Attention is currently required from: Christian Walter, Eric Lai, Kapil Porwal, Nick Vaccaro, Paz Zcharya, Shelley Chen, Subrata Banik.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79736?usp=email )

Change subject: security/tpm: Retrieve factory configuration for device w/ Google TPM
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File src/security/tpm/tss/tcg-2.0/tss_structures.h:

https://review.coreboot.org/c/coreboot/+/79736/comment/b7d4b5d2_12cbc0c7 :
PS3, Line 360: 	uint64_t factory_config;
I'm not sure if we're concerned about gaps in these structs, but it's probably best to make sure they're filled in. In this case, there's a 5-byte gap between the union and `factory_config`, which can be filled with padding:

```
struct vendor_command_response {
    uint16_t vc_subcommand;
    union {
    	uint8_t num_restored_headers;
    	uint8_t recovery_button_state;
    	uint8_t tpm_mode;
    	uint8_t boot_mode;
    };
    uint8_t padding[5];
    /*
     * bits 63..8 : reserved
     * bits 7..0 : factory config
     */
    uint64_t factory_config;
}
```