[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add unmask eint event for bootblock

[Yidi Lin (Code Review)]

Attention is currently required from: Chhao Chang, Jarried Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )

Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock
......................................................................

Patch Set 17:

(3 comments)

File src/soc/mediatek/common/eint_event.c:

https://review.coreboot.org/c/coreboot/+/84025/comment/5927c2b3_3fb15235?usp... :
PS17, Line 15: uintptr_t reg;
```
uint32_t *reg = (uint32_t *)(base + EVENT_CLEAN_MASK_OFFSET);
for (i = 0; i < port; i++)
    write32p(reg[i], EINT_VALUE);
```

https://review.coreboot.org/c/coreboot/+/84025/comment/eb8368fd_0307d4fa?usp... :
PS17, Line 8: #define EVENT_CLEAN_MASK_OFFSET	0x880
            : #define EVENT_MASK_OFFSET	0x800
            : #define EINT_VALUE		0xFFFFFFFF
            : 
            : void enable_eint_event(uintptr_t base, unsigned int port)
            : {
            : 	unsigned int i;
            : 	uintptr_t reg;
            : 
            : 	for (i = 0; i < port; i++) {
            : 		reg = base + EVENT_CLEAN_MASK_OFFSET + (i << 2);
            : 		write32((uint32_t *)reg, EINT_VALUE);
            : 	}
            : }
you can move those to eint_event_common.c

File src/soc/mediatek/common/include/soc/eint_event.h:

https://review.coreboot.org/c/coreboot/+/84025/comment/75037d3c_eec84944?usp... :
PS17, Line 17: struct eint_info {
             : 	uintptr_t base;
             : 	unsigned int eint_num;
             : };
move to mt8196/eint_event.c