Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33235 )
Change subject: cpu/x86/smm: Add STM Support ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33235/2/src/cpu/x86/smm/smm_module_handler.c File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/#/c/33235/2/src/cpu/x86/smm/smm_module_handler.c... PS2, Line 168: if(smm_runtime->mseg != 0) { // has the STM been loaded
space required before the open parenthesis '('
Done
https://review.coreboot.org/#/c/33235/2/src/cpu/x86/smm/smm_module_handler.c... PS2, Line 170: InitMseg.lo = smm_runtime->mseg | IA32_SMM_MONITOR_VALID;
line over 80 characters
Done