Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Kane Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77614?usp=email )
Change subject: soc/intel/common: Add functions for getting address bits taken by MKTME
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/77614/comment/235d45da_78fbded4 :
PS1, Line 504: get_tme_bit_size
why don't you move this function as helper inside cpu_common?
u can always use the TME support check and subtract the reserve range from the available size (cpu_phys_address_size()).
I don't feel the need of having a weak implementation and override.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77614?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib60e8da58fcc789e99ba93b177c1dff6b635f116
Gerrit-Change-Number: 77614
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Sat, 02 Sep 2023 15:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment