Hi Robin, welcome to coreboot!
I left a bunch of comments around the files. Feel free to ask if you have any doubts 😄
Patch Set 10:
(11 comments)
Patch Set 9:
Patch Set 6:
(11 comments)
Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov
If yes, then the vendor is Gigabyte.
No, it is not GA-H61M-S1 but onlu H61m-S1. It's seems to be a chinese version of this board
only*
Felix, the board is completely different. Here's a picture I found:
https://i0.wp.com/ae01.alicdn.com/kf/H2ef1edff41744124861983142fb86314f/H61M-S1-font-b-LGA-b-font-font-b-1155-b-font-font-b-Motherboard-b.jpg
19 comments:
Patch Set #14, Line 7: mb/ongy/h61m-s1: Add new mainboard
Add an empty line between the commit summary and the commit message:
mb/ongy/h61m-s1: Add new mainboard
Port done using the autoport utility.
Patch Set #14, Line 15: Integrated VGA and HDMI works
Was this with libgfxinit? (the default graphics init for most Intel iGPUs)
Patch Set #14, Line 17: Seabios
SeaBIOS
File src/mainboard/ongy/h61m-s1/Kconfig:
config VGA_BIOS_FILE
string
default "pci8086,0112.rom"
config VGA_BIOS_ID
string
default "8086,0112"
Remove this, it depends on the installed CPU
onfig DRAM_RESET_GATE_GPIO
int
default 60
This is not correct. GPIO60 is configured as native mode on your board. If ACPI S3 suspend/resume work correctly, you can remove it. Otherwise, we will have to guess the correct GPIO.
File src/mainboard/ongy/h61m-s1/acpi_tables.c:
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
This does nothing. The gnvs struct is cleared before calling this function
File src/mainboard/ongy/h61m-s1/devicetree.cb:
register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_dp_b_hotplug" = "4"
register "gpu_dp_c_hotplug" = "4"
register "gpu_dp_d_hotplug" = "4"
register "gpu_panel_power_cycle_delay" = "4"
These settings aren't needed for a desktop board
0
0
0
Patch Set #14, Line 25: register "docking_supported" = "0"
This defaults to zero already. You can remove it
Patch Set #14, Line 27: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
This defaults to zero already. You can remove it
device pci 00.0 on # Host bridge Host bridge
subsystemid 0x8086 0x0100
end
device pci 01.0 on # PEG
subsystemid 0x8086 0x0101
end
device pci 02.0 on # iGPU
subsystemid 0x8086 0x2010
end
Please move these entries above the southbridge block. That is, before this line:
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH
File src/mainboard/ongy/h61m-s1/dsdt.asl:
Patch Set #10, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
yes, it seems to be used for integrated GPU
It's only used on Lenovo mainboards. Please remove
File src/mainboard/ongy/h61m-s1/dsdt.asl:
Patch Set #14, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Unused, can remove
Capitalize: "Global"
Patch Set #14, Line 29: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Not needed for a desktop board without an integrated panel
File src/mainboard/ongy/h61m-s1/gma-mainboard.ads:
Patch Set #14, Line 10: private package GMA.Mainboard is
Almost all the gma_mainboard.ads files in coreboot are indented with three spaces, instead of tabs. Please do the same here
File src/mainboard/ongy/h61m-s1/mainboard.c:
If you don't plan on using the VGA BIOS, I would remove this and the `select INTEL_INT15` line from Kconfig
To view, visit change 40813. To unsubscribe, or for help writing mail filters, visit settings.