Patch Set 4:

Heads up - Somebody from Intel commented on https://github.com/IntelFsp/FSP/issues/15 and says it has something to do with coreboot setting the UARTs to ACPI mode. The suggested fix is to conditionally set PcdEnableHsuart0 and PcdEnableHsuart1 (see the issue on Github for details).

Intel provided fix in routine, which is not available in coreboot (Intel fix is based on soc\intel\fsp_braswell where coreboot uses soc\intel\braswell).
The problem is not the configuration of the HSUART, but the internal UART is enabled. Having this internal UART enabled, causes external UART (0x3F8) can not be used/accessed.

FSP enables the internal using 'SerialPortEnable' which is a build option and can not be configured external.

Imo this issue has not a coreboot cause, but still an Intel FSP bug.

View Change

To view, visit change 28464. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb6c9e4153b3de58791b211c7f4241be3bceae9d
Gerrit-Change-Number: 28464
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin@intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy@intel.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 11:05:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment