Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )
Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML ......................................................................
Patch Set 7:
@Nico, i'm requesting you to remove your personal battle between
coreboot and FSP and consider your -2, this patch is nowhere eligible for -2, when i'm giving you complete inside and proposing to change the design ASAP.
Subrata, -2 simply means the change should not be merged *as is*. When the author already agreed to change it, how is it not eligible? When I give a -2, I reconsider it on every following revision of the change. Even if it was just an update to the commit message to better reflect the changes.
[Subrata] Nice to know this.
For now we are in middle of product and creating roadblock like
this is against good development,
When is anybody not in the middle of a product? With your argument the only right time to write propper code is during vacation? I don't see how this is a roadblock. You seem to have plenty of time to argue about 10 lines of code but zero time to change them???
[Subrata] If i had zero time to change then then wy should i let this patch open for 7 days to hear lots of things from you. I'm only requesting you to be reasonable and giving proper picture against your above comment
"But please ask your FSP team to do such cleanups to all FSP plat- forms in parallel so FSP users don't have to suffer."
My only intention to let you know that this time its not possible to make changes in FSP and its old code base but seems you "don't care about that". thats okay.
And i can point out many patch in cb.org those are not for sure meant for any product ? those are improvement. There is clearly difference between working on datelines vs wish to make things perfect.
do you want to should not push patch into coreboot.org? i think
thats your only intention too me. This is going out of control for now.
Nope, rather the opposite. I appreciate your contributions to coreboot.org. I wouldn't spent hours of review every day if I wouldn't care about it.
That I gave the -2 was rather symbolic. You were talking about a potential future clean-up while it seemed to me that Maulik already agreed to update this change. I just want to make sure you're not whipping him not to update.
[Subrata] I don't understand which part Maulik agrees to update in code based on your comment. i do care about this change as author of this CL.