8 comments:
File util/qualcomm/createxbl.py:
Patch Set #17, Line 269: secure_type = image_header_secflag, header_version = header_version )
nit: on a new line?
Done
Patch Set #17, Line 673: if header_version == 5 or header_version == 6:
nit: probably makes more sense to check < 4 (since presumably this will stay this way for future ver […]
Explicitly checking for version 5 and 6 makes much sense, it is more user-friendly.
Patch Set #17, Line 687: if header_version == 5 or header_version == 6:
same
same
File util/qualcomm/mbn_tools.py:
Patch Set #17, Line 74: MBN_HEADER_VERSION_6 = 6 # Mbn header_version 6
nit: not really sure these constants are that useful as opposed to just using the numbers
It is always good to have constants which are pointing to numbers, even SHA256_SIGNATURE_SIZE is also declared same
Patch Set #17, Line 578: if self.flash_parti_ver == MBN_HEADER_VERSION_6:
nit: maybe > 5?
Currently, 7,8,9 and later are not supported so this will be confusing to add check like this
Patch Set #17, Line 593: if self.flash_parti_ver == MBN_HEADER_VERSION_6:
same
same reply
Patch Set #17, Line 1009: if header_version == MBN_HEADER_VERSION_5:
This should probably be […]
Equality checking here is much more sensible then comparison.
Patch Set #17, Line 2134: if header_version == MBN_HEADER_VERSION_6:
All the review comments will be addressed by Rishabh Sharma. He is looking in to it.
same reply as above
To view, visit change 35506. To unsubscribe, or for help writing mail filters, visit settings.