Attention is currently required from: Martin L Roth, Paul Menzel.
3 comments:
Patchset:
A couple of nits, Feel free to fix them in a follow-on patch if you're going to fix them. […]
Ack. I think a lot of that is just the result of autoport, which often just dumps raw register values and doesn't attempt to decode them into macros. I'll probably fix some of them in a follow up patch that changes them across several boards
File src/mainboard/dell/e6430/cmos.layout:
nit: 414? Is there a reason to skip a bit here?
Fixed. That was just leftover from the T430 cmos.layout which I based mine off of, which uses bit 414 for a touchpad option, and I had removed that option in my layout.
File src/mainboard/dell/e6430/early_init.c:
Patch Set #6, Line 29: PCI_DEV(0, 0x1f, 0), 0x82, 0x1c0f
Nit: These could be macros to better show what's being initialized.
Done
To view, visit change 77444. To unsubscribe, or for help writing mail filters, visit settings.