View Change

2 comments:

• File src/soc/intel/jasperlake/romstage/romstage.c:

  • Patch Set #2, Line 138: if (!s3wake)

    I think it is safe to do the call to cse_fw_sync() before save_dimm_info() and also restrict the call to happen only in !s3wake.

  • Patch Set #2, Line 142: cse_fw_sync();

    I wonder if we should add dram_init_done_hooks just like we have cbmem_init_hooks. That will allow cse driver to register the hook which will be run after dram init is done. Then we don't really need to add this to each SoC. We can probably do that later on, but something that will save per-SoC effort.

To view, visit change 48280. To unsubscribe, or for help writing mail filters, visit settings.