Thanks for the review!
4 comments:
Needs slight update.
Done
File src/ec/kontron/kempld/chip.h:
Patch Set #13, Line 19: I2C_FREQ_MAX = 2700,
Nit, technically these should have a KEMPLD_ prefix. All the `chip.h` are […]
Done
File src/ec/kontron/kempld/kempld_i2c.c:
Patch Set #13, Line 254: BIOS_WARNING
Warning is a bit too high, from `commonlib/loglevel.h`: […]
In that case, is BIOS_INFO okay?
Patch Set #13, Line 256: config->i2c_frequency);
Nit, while not mandated, it would be nice to have braces around the branches […]
Done
To view, visit change 44476. To unsubscribe, or for help writing mail filters, visit settings.