Patch set 3:Code-Review +1
14 comments:
File src/soc/amd/picasso/Kconfig:
Patch Set #3, Line 16: STONEYRIDGE
looks like it is intentional
File src/soc/amd/picasso/chip.c:
Patch Set #3, Line 17: include <console/console.h>
if I'm not wrong, this is not used
Patch Set #3, Line 35: stoneyridge
is it intentional?
Patch Set #3, Line 42: stoney
is it intentional?
File src/soc/amd/picasso/enable_usbdebug.c:
Patch Set #3, Line 22: <device/pci_def.h
maybe not used?
File src/soc/amd/picasso/include/soc/northbridge.h:
Patch Set #3, Line 17: PI_STONEYRIDGE_NORTHBRIDGE_H
?
File src/soc/amd/picasso/include/soc/nvs.h:
Patch Set #3, Line 20: stoneyridge
is it intentional?
Patch Set #3, Line 24: __SOC_STONEYRIDGE_NVS_H__
?
File src/soc/amd/picasso/include/soc/pci_devs.h:
__PI_STONEYRIDGE_PCI_DEVS_H__
#define __PI_STONEYRIDGE_PCI_DEVS_H__
?
File src/soc/amd/picasso/include/soc/romstage.h:
Patch Set #3, Line 16: __STONEYRIDGE_ROMSTAGE_H__
?
File src/soc/amd/picasso/include/soc/smbus.h:
Patch Set #3, Line 16: _STONEYRIDGE
is it intentional?
File src/soc/amd/picasso/include/soc/smi.h:
Patch Set #3, Line 18: SOUTHBRIDGE_AMD_PI_STONEYRIDGE
?
File src/soc/amd/picasso/include/soc/southbridge.h:
Patch Set #3, Line 17: _STONEYRIDGE
?
File src/soc/amd/picasso/tsc_freq.c:
Patch Set #3, Line 33: Family 15h Models 70h-7Fh
17h ?
To view, visit change 32407. To unsubscribe, or for help writing mail filters, visit settings.