Attention is currently required from: Iru Cai (vimacs).
9 comments:
File src/ec/dell/mec5055/early_init.c:
Is it necessary to have a separate file for this one function?
Patch Set #5, Line 7: u8 buf[32], c;
Initialise the buffer?
u8 buf[32] = { 0 };
File src/ec/dell/mec5055/mec5055.h:
#include <stddef.h>
#include <stdint.h>
Already provided by `types.h`
File src/ec/dell/mec5055/mec5055.c:
Patch Set #5, Line 4: #include <console/console.h>
nit: also #include <types.h> here
This 0x20 is the same numeric value as the `32` in early_init.c, why not #define it?
Patch Set #5, Line 21: start >= 0x20
This check is redundant. Either `count` is positive (non-zero) and the other check is true, or `count` is zero and the code does nothing.
Patch Set #5, Line 56: write arguments to EC[2:]
I *really* don't like this kind of buffer handling. Why not have separate parameters for the command and the buffer?
Patch Set #5, Line 59: result may starts at EC[0] or EC[1]
Why this difference? Does the EC handle some commands differently?
Patch Set #5, Line 59: starts
no `s` at the end: start
To view, visit change 44975. To unsubscribe, or for help writing mail filters, visit settings.