Together with Balazs Vinarz we tried our best to address all the comments, and I've been constantly backporting the changes made to F2A85-M sources. So, I believe: this A88XM-E source is even better than F2A85-M in a coreboot master, as it went through more scrutinity and has some improvements which F2A85-M source lacks. I don't see any obstacles serious enough to delay this merging - also considering that this change has been initially submitted almost 1.5 years ago and sadly we've missed a great chance to get this merged before a coreboot 4.12. After re-testing this on my A88XM-E I'm going to vote +2 for this Balazs change: hope it's acceptable to do, despite I've spent so much time on this code.

Patch set 58:Code-Review +1

View Change

To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.