1 comment:
File src/soc/intel/common/block/reset/reset.c:
Patch Set #7, Line 27: do_force_global_reset
Second, do_global_reset is only ever called from do_force_global_reset, so why not move the prior to the latter?
do_global_reset() is calling from below common reference hence we might need to change that code as well to make something meaning full. Finally do_force_global_reset() can be renamed as pmc_assist_global_reset() which is the actual case ?
See, how I am confused? :P Actually I meant "do_force_global_reset is only ever called from do_global_reset".
Never mind, I understood what u meant 😊
What about this?static void force_global_reset(void)
{
if (cse_request_global_reset())
return; /* TODO: or halt()? *//*
* If ME is unable to reset platform then enable the PMC CF9GR register and
* force a global reset by writing 0x06 or 0x0E.
*/pmc_global_reset_enable(true);

/* Now BIOS can write 0x06 or 0x0E to 0xCF9 port to global reset platform */
 do_full_reset(); // another really_really_do_... ;-)
}

Is this reasonable enough ? hence we can avoid the need of another static function ?
void do_global_reset(void)
{
/* Ask CSE to do the global reset */
if (cse_request_global_reset(GLOBAL_RESET))
return;
/*
* If ME is unable to reset platform then enable the PMC CF9GR register and
* force a global reset by writing 0x06 or 0x0E.
*/
pmc_global_reset_enable(true);
/* Now BIOS can write 0x06 or 0x0E to 0xCF9 port to global reset platform */
do_full_reset();
}
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.