Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Felix Held, Jincheng Li, Johnny Lin, Jonathan Zhang, Nico Huber, Paul Menzel, Shuo Liu, TangYiwei, Tim Chu.

View Change

4 comments:

• File src/soc/intel/xeon_sp/gnr/Kconfig:

  • Patch Set #56, Line 17: select FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND

    I don't remember if I mentioned this, but it would be great to fix FSP

    Intel said this issue is not present on GNR, so this is wrong.

• File src/soc/intel/xeon_sp/gnr/chip.c:

  • Patch Set #56, Line 13: intelblocks

    do you need all those headers?

• File src/soc/intel/xeon_sp/gnr/cpu.c:

  • Patch Set #56, Line 9: common

    do you need all those headers?

• File src/soc/intel/xeon_sp/gnr/romstage.c:

  • Patch Set #56, Line 5: #include <console/console.h>

    do you need all those headers?

To view, visit change 81316. To unsubscribe, or for help writing mail filters, visit settings.