13 comments:
Patch Set #39, Line 167: #define VBOOT2_TPM_LOG(addr, size) \
Macros with multiple statements should be enclosed in a do - while loop
Patch Set #39, Line 167: #define VBOOT2_TPM_LOG(addr, size) \
macros should not use a trailing semicolon
Patch Set #39, Line 50: uint32_t tpm_extend_pcr(int pcr, const char *digest_type, uint8_t *digest, size_t digest_len,
line over 80 characters
File src/security/tpm/tspi/log.c:
Patch Set #39, Line 37: size_t tcpa_log_len = sizeof(struct tcpa_table) + MAX_TCPA_LOG_ENTRIES * sizeof(struct tcpa_entry);
line over 80 characters
Patch Set #39, Line 40: if (!tclt && IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY)) {
line over 80 characters
Patch Set #39, Line 43: if (strncmp(TCPA_LOG_HEADER, (const char *)tclt->header, sizeof(tclt->header))) {
line over 80 characters
Patch Set #39, Line 44: tclt->max_entries = MAX_PREMEM_TCPA_LOG_ENTRIES;
line over 80 characters
Patch Set #39, Line 46: strncpy((char *)tclt->header, TCPA_LOG_HEADER, sizeof(tclt->header));
line over 80 characters
Patch Set #39, Line 54: strncpy((char *)tclt->header, TCPA_LOG_HEADER, sizeof(tclt->header));
line over 80 characters
Patch Set #39, Line 60: if (strncmp(TCPA_LOG_HEADER, (const char *)tclt->header, sizeof(tclt->header))) {
line over 80 characters
Patch Set #39, Line 63: strncpy((char *)tclt->header, TCPA_LOG_HEADER, sizeof(tclt->header));
line over 80 characters
Patch Set #39, Line 99: void tcpa_log_add_table_entry(const char *name, const uint32_t pcr, const char *digest_type,
line over 80 characters
File src/security/vboot/secdata_tpm.c:
Patch Set #39, Line 86: return tpm_extend_pcr(pcr, "SHA256", buffer, size, TPM_PCR_GBB_HWID_NAME);
line over 80 characters
To view, visit change 29563. To unsubscribe, or for help writing mail filters, visit settings.