Attention is currently required from: Paul Menzel, Zhi7 Li.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 12: (Auto-Generated by create_coreboot_variant.sh version 4.5.0).
Please move the dot/period before the ).
1. This commit was Auto-Generated by new_variant.py script.
2. If move dot before the ')', like this "version 4.5.0.)", looks strange.
Could we just keep or delete the dot?
To view, visit change 57358. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d52be55270361406a67f91707b71dff5c725f35
Gerrit-Change-Number: 57358
Gerrit-PatchSet: 1
Gerrit-Owner: Zhi7 Li <lizhi7@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin@huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Krystal Han <hanlijing@huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Zhi7 Li <lizhi7@huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 09:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment