Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41215 )
Change subject: mb/google/volteer: Add firmware configuration table ......................................................................
Patch Set 18: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/41215/18/src/mainboard/google/volte... File src/mainboard/google/volteer/fw_config.c:
https://review.coreboot.org/c/coreboot/+/41215/18/src/mainboard/google/volte... PS18, Line 60: fw_config_handle This is okay for now, but this breaks our override gpio mechanism. I think we need to extend the gpio override function to accept an array of override tables to apply the required overrides. We don't need to solve it in this CL. I can push some patches for the API since it might be required for some other changes for the variants as well.
https://review.coreboot.org/c/coreboot/+/41215/18/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41215/18/src/mainboard/google/volte... PS18, Line 1: fw_config I really like the way this is being implemented. It feels very easy to use and extend :).