1 comment:
test -n "$(SPD_SOURCES)" || \
(echo "HAVE_SPD_BIN_IN_CBFS is set but SPD_SOURCES is empty" && exit 1)
In my opinion, we should allow a board to have empty SPD_SOURCES even when HAVE_SPD_IN_CBFS is set. This is very useful for variants of a board which start out with minimal changes (or use templates to add the initial support) and follow up with more variant-specific changes to enable other bits. What we really want to ensure here is that we don't accidentally drop SPD ROM data if SPD_SOURCES is not empty.
Thus it should be left upto the mainboard/variant to control when it is ready to add the SPD files.
Thoughts?
To view, visit change 45131. To unsubscribe, or for help writing mail filters, visit settings.