Patch Set 1: Code-Review+1

Was it useful to you?

Yes, at least it helps to figure out the vendor/device IDs (easy) and Bitmap (hard). For example, I still don't understand the Bitmap value: what is it, where it comes from and how it affects the things. So I flashed a proprietary UEFI, used a getpir utility and it told me that Lenovo G505S has 0xdc90 bitmap - which seems to work. It also helped me with some entries, although the end result is very different (sadly I lost this original getpir output so can't compare at the moment).

View Change

To view, visit change 48322. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieff7673387ae9275b8271f4a483926b774697a8d
Gerrit-Change-Number: 48322
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc@intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 06 Dec 2020 16:59:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment