Nico Huber submitted this change.
src/mainboard/*.asl: Remove _HID / _ADR objects overlapping
ACPI spec:
"A device object must contain either an _HID object or an _ADR
object, but should not contain both."
Signed-off-by: Jonas Moehle <ad-min@mailbox.org>
Change-Id: I949393558f5af66689c167b2e593a1461f641962
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37935
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/aopen/dxplplusu/acpi/p64h2.asl
M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl
M src/mainboard/intel/strago/acpi/mainboard.asl
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl b/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl
index e3f2e5f..ccaa6e3 100644
--- a/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl
+++ b/src/mainboard/aopen/dxplplusu/acpi/p64h2.asl
@@ -18,7 +18,6 @@
/* I/O APIC id 0x3 */
Device(PBIO)
{
- Name (_HID, "ACPI000A")
Name (_ADR, 0x001c0000)
}
@@ -59,7 +58,6 @@
/* I/O APIC id 0x4 */
Device(PAIO)
{
- Name (_HID, "ACPI000A")
Name (_ADR, 0x001e0000)
}
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl
index 01942dc..9b88cdd 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl
+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl
@@ -18,7 +18,6 @@
/* Grunt specific I2S machine driver */
Device (I2S)
{
- Name (_ADR, 1)
Name (_HID, "AMD7219")
Name (_CID, "AMD7219")
diff --git a/src/mainboard/intel/strago/acpi/mainboard.asl b/src/mainboard/intel/strago/acpi/mainboard.asl
index 1d5437b..caaae86 100644
--- a/src/mainboard/intel/strago/acpi/mainboard.asl
+++ b/src/mainboard/intel/strago/acpi/mainboard.asl
@@ -114,7 +114,7 @@
/* Realtek Audio Codec */
Device (RTEK) /* Audio Codec driver I2C */
{
- Name (_ADR, 0)
+
Name (_HID, AUDIO_CODEC_HID)
Name (_CID, AUDIO_CODEC_CID)
Name (_DDN, AUDIO_CODEC_DDN)
To view, visit change 37935. To unsubscribe, or for help writing mail filters, visit settings.