I don't really understand what this does. Code-wise it seems fine.
Patch set 5:Code-Review +2
1 comment:
File src/soc/mediatek/mt8183/mt6358.c:
Patch Set #5, Line 786: vsim2_cali_0mv = (vsim2_cali_0mv > 6) ? (vsim2_cali_0mv - 6) : 0;
I assume we've somehow made sure that this cannot run twice and subtract the value twice? Does this code guarantee that the PMIC will be reset and all registers return to power-on values on every boot? (Please don't just base this of Kukui-specific board design... this code should do the right thing for all possible MT8183 boards.)
To view, visit change 32057. To unsubscribe, or for help writing mail filters, visit settings.