View Change

7 comments:

• File src/cpu/x86/smm/smm_module_handler.c:

  • Patch Set #1, Line 179: console_init();

    code indent should use tabs where possible

  • Patch Set #1, Line 179: console_init();

    please, no space before tabs

  • Patch Set #1, Line 179: console_init();

    please, no spaces at the start of a line

  • Patch Set #1, Line 203: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset);

    line over 80 characters

  • Patch Set #1, Line 220: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu,

    trailing whitespace

• File src/cpu/x86/smm/smm_module_loader.c:

  • Patch Set #1, Line 272:

    trailing whitespace

  • Patch Set #1, Line 272:

    please, no spaces at the start of a line

To view, visit change 33235. To unsubscribe, or for help writing mail filters, visit settings.