build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33235 )
Change subject: cpu/x86/smm/ STM Support ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 179: console_init(); code indent should use tabs where possible
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 179: console_init(); please, no space before tabs
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 179: console_init(); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 203: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, smm_runtime->start32_offset); line over 80 characters
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_handler.c... PS1, Line 220: SetupSmmDescriptor(smbase, smm_runtime->save_state_size, cpu, trailing whitespace
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_loader.c File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_loader.c@... PS1, Line 272: trailing whitespace
https://review.coreboot.org/#/c/33235/1/src/cpu/x86/smm/smm_module_loader.c@... PS1, Line 272: please, no spaces at the start of a line