Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
mb/*/Kconfig: Drop select USE_OPTION_TABLE

Only 4 mainboards selected to use the option table.
Use the same default on all boards.

Change-Id: Ia9ef88d5158a2b43f843c26b5b366a899dad8788
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52855
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/apple/macbook21/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/am1i-a/Kconfig
M src/mainboard/lenovo/x60/Kconfig
4 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig
index 9eb06ff..5d8f626 100644
--- a/src/mainboard/apple/macbook21/Kconfig
+++ b/src/mainboard/apple/macbook21/Kconfig
@@ -15,7 +15,6 @@
select INTEL_INT15
select HAVE_ACPI_TABLES
select HAVE_ACPI_RESUME
- select USE_OPTION_TABLE
select I945_LVDS

config MAINBOARD_DIR
diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig
index af723a3..4e9583c 100644
--- a/src/mainboard/asrock/h81m-hds/Kconfig
+++ b/src/mainboard/asrock/h81m-hds/Kconfig
@@ -32,12 +32,4 @@
string
default "H81M-HDS"

-#
-# Since this is a desktop board, the assumption is made that most users
-# would want CMOS configuration enabled by default.
-#
-config USE_OPTION_TABLE
- bool
- default y
-
endif
diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig
index 78948b2..365043c 100644
--- a/src/mainboard/asus/am1i-a/Kconfig
+++ b/src/mainboard/asus/am1i-a/Kconfig
@@ -7,7 +7,6 @@
select FORCE_AM1_SOCKET_SUPPORT
select GFXUMA
select HAVE_OPTION_TABLE
- select USE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
select HAVE_PIRQ_TABLE
select HAVE_ACPI_RESUME
diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig
index 8397835..3a82179 100644
--- a/src/mainboard/lenovo/x60/Kconfig
+++ b/src/mainboard/lenovo/x60/Kconfig
@@ -21,7 +21,6 @@
select BOARD_ROMSIZE_KB_2048
select HAVE_ACPI_TABLES
select HAVE_ACPI_RESUME
- select USE_OPTION_TABLE
select DRIVERS_LENOVO_WACOM
select I945_LVDS
select INTEL_GMA_HAVE_VBT

To view, visit change 52855. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9ef88d5158a2b43f843c26b5b366a899dad8788
Gerrit-Change-Number: 52855
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged