Patch Set 2:

Without this, we can't enforce re-training in manufacturing process.
It is not as much to force retraining. This command was added on x86 to ensure that recovery mode training data is generated and saved for future uses.

Well... I agree we may have slightly changed its usage.

If that data already exists, there is no need to force training. That is the primary reason why Julius pushed this revert.

Then can we have another flag to enforce re-training?
How does x86 deal with that?

We have not really encountered any case where we had to force retraining in factory. Is that what is required on non-x86 platforms? Can the saved training data be simply erased by factory scripts?

View Change

To view, visit change 40623. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5df5e00526e90cb573131de3c8bac9f85f4e3a5f
Gerrit-Change-Number: 40623
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 23 Apr 2020 03:49:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment