1 comment:
File src/arch/x86/assembly_entry.S:
Patch Set #20, Line 24: call gdt_init
We're doing #if/#else just for different symbol names on a construct that should fundamentally not matter to romstage. I feel like we could just change the name of the symbols to a common name to reduce the noise.
_car_stack/_ecar_stack seems to be used in several x86 files and 1 riskv one; maybe 17 total. I'm not opposed to a patch to commonize the name, but I'm not sure how others would feel about it. We'd started out attempting to piggyback on the _car names but IIRC Kyõsti didn't think that was appropriate.
Otherwise I'm not sure how else I'd reduce the noise. The #if/else/endif selection above could maybe be moved into rules.h and maybe call it something like PRERAM_STACK_TOP.
To view, visit change 35035. To unsubscribe, or for help writing mail filters, visit settings.