Attention is currently required from: Daniel Peng, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/84894?usp=email )
Change subject: mb/google/nissa/var/glassway: Add touch screen ILIT2901 support
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84894/comment/e623d64b_345e11fd?usp... :
PS4, Line 18: 2. Confirm command evtest and touchscreen function is workable.
Just out of curiosity, and maybe for the future, do the coreboot logs contain the detected touchscreen model? If so, this could be added to the TEST= section.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84894?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6e13c948edca5a894e1a00a1954f0f88c4a079cf
Gerrit-Change-Number: 84894
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 29 Oct 2024 07:29:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes