1 Jan
2022
1 Jan
'22
10:51 p.m.
Attention is currently required from: Nico Huber, Subrata Banik, Tim Wawrzynczak, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60470 )
Change subject: console: Make get_log_level a public function ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60470/comment/7eb74df2_f8d588a8 PS4, Line 10: rather nit: rather *than*
File src/include/console/console.h:
https://review.coreboot.org/c/coreboot/+/60470/comment/2ed45e3f_1217add7 PS4, Line 66: 0 0 is BIOS_EMERG, should we return `-1` instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56349f22c71c9db757b2be8eeb2dbfe959f80397
Gerrit-Change-Number: 60470
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 01 Jan 2022 21:51:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment