Attention is currently required from: Ravi kumar, mturney mturney, Julius Werner, Rajesh Patil.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: mb/google/herobrine: Initialize EC and TPM devices
......................................................................
Patch Set 97:
(1 comment)
File src/mainboard/google/herobrine/chromeos.c:
https://review.coreboot.org/c/coreboot/+/50581/comment/96d4327d_f303d73f
PS97, Line 31: #if CONFIG(EC_GOOGLE_CHROMEEC)
I couldn't figure out a better way to do as variable length arrays are not allowd in C. It seems like in trogdor we just define the EC and TPM gpios for bubs even though they are not used, but that doesn't seem correct. Would really appreciate it if others have any suggestions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c
Gerrit-Change-Number: 50581
Gerrit-PatchSet: 97
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 06 Jan 2022 01:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment