Patrick Georgi submitted this change.
mb/{google/jecht,intel/wtm2}: Remove NOOP APM finalize call
The intel/soc/broadwell smihandler has no handler for this APM call.
Change-Id: I2bcec7cce00d433a197a9e2fb01434a2998e1452
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52167
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/jecht/mainboard.c
M src/mainboard/intel/wtm2/mainboard.c
2 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/src/mainboard/google/jecht/mainboard.c b/src/mainboard/google/jecht/mainboard.c
index 786695d..7fdcce8 100644
--- a/src/mainboard/google/jecht/mainboard.c
+++ b/src/mainboard/google/jecht/mainboard.c
@@ -1,16 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h>
-#include <cpu/x86/smm.h>
#include <vendorcode/google/chromeos/chromeos.h>
#include "onboard.h"
-void mainboard_suspend_resume(void)
-{
- /* Call SMM finalize() handlers before resume */
- apm_control(APM_CNT_FINALIZE);
-}
-
static void mainboard_init(struct device *dev)
{
lan_init();
diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c
index 48568cd..e9583ac 100644
--- a/src/mainboard/intel/wtm2/mainboard.c
+++ b/src/mainboard/intel/wtm2/mainboard.c
@@ -1,17 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/x86/smm.h>
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
-#include <acpi/acpi.h>
#include <vendorcode/google/chromeos/chromeos.h>
-void mainboard_suspend_resume(void)
-{
- /* Call SMM finalize() handlers before resume */
- apm_control(APM_CNT_FINALIZE);
-}
-
// mainboard_enable is executed as first thing after
// enumerate_buses().
To view, visit change 52167. To unsubscribe, or for help writing mail filters, visit settings.