Fixed most of the PEP8 errors.
8 comments:
Patch Set #3, Line 1: #!/usr/bin/env python
Starting comments. […]
"/usr/bin/env python" as it's compatible to python2 and python3.
if self.blob_as_ord(offset) != i:
continue
if not self.verify_match(i, offset):
continue
nit: The multiple "continue"s followed by the return are a bit harder to read than is necessary. […]
Done
Patch Set #3, Line 99: def get_matches(self):
This function does not use "self". […]
Done
Patch Set #3, Line 149: if offset + 0x15c > len(self.blob):
This looks like it should be >=, given that you are indexing self.blob[offset + 0x15c] below. […]
Done
Patch Set #3, Line 155: if offset + 0x141 > len(self.blob):
This should also be >=
Done
Patch Set #3, Line 161: if offset + 0x7d > len(self.blob):
Again here
Done
offset = 0
length = 0
Dead code can be deleted.
Done
Patch Set #3, Line 212: fn = open(filename, "w")
idiomatic Python is to use a "with" block here to ensure that all variants of Python will properly f […]
Done
To view, visit change 31385. To unsubscribe, or for help writing mail filters, visit settings.