What should I do to make this patchset acceptable for YOU? The current COUPLED measurement also starts extending in bootblock, verstage, or romstage, since "verstage" could be a part of bootblock on platforms with enough space for it.

I really want a clear explanation for and discussion on why the patch set 63 approach does not work from the people who -2ed it. I have now asked for this *multiple* times (both here and on other channels) and there's nothing but silence coming back. Just crapping all over a CL with vague concerns but completely refusing to discuss it in detail is not a proper way to collaborate on an open-source project.

The other approach is just plain *better*. It is a lot cleaner, keeps dependencies from spreading all over the place, covers edge cases that even the current implementation doesn't and *does not change anything about when stuff is measured for the current use cases!* If you want to make progress on this CL, please revert to that patch set and I will +2 it. If we then see -2s again without willingness to discuss on a technical level I will escalate the matter as necessary.

View Change

To view, visit change 35077. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fb376b4a8b98baffaee4d574937797bba1f8aee
Gerrit-Change-Number: 35077
Gerrit-PatchSet: 69
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Joel Kitching <kitching@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Shawn C <citypw@hardenedlinux.org>
Gerrit-Comment-Date: Thu, 19 Mar 2020 23:44:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment